Skip to content

Comments

Update documentation to reflect refactored parse_standalone_function_call implementation#9

Merged
byteshiftlabs merged 1 commit intofeature/function_callsfrom
copilot/sub-pr-7
Oct 30, 2025
Merged

Update documentation to reflect refactored parse_standalone_function_call implementation#9
byteshiftlabs merged 1 commit intofeature/function_callsfrom
copilot/sub-pr-7

Conversation

Copy link
Contributor

Copilot AI commented Oct 30, 2025

The documentation in docs/source/internals/parser.rst shows an outdated implementation of parse_standalone_function_call() with inline argument parsing logic. The actual implementation was refactored to delegate to the shared parse_function_call_args() helper function.

Changes

  • Update code example in parser documentation (lines 1132-1175) to match current implementation that uses parse_function_call_args() instead of inline argument parsing

Current documented implementation (outdated):

static ASTNode* parse_standalone_function_call(FILE *input, const char *function_name)
{
    // ... inline argument parsing with while loop ...
    consume(input, TOKEN_SEMICOLON);
}

Actual implementation (needs to be documented):

static ASTNode* parse_standalone_function_call(FILE *input, const char *function_name)
{
    func_call_node = parse_function_call_args(input, function_name);
    consume(input, TOKEN_SEMICOLON);
}

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Update function call support in expressions and documentation Update documentation to reflect refactored parse_standalone_function_call implementation Oct 30, 2025
Copilot AI requested a review from byteshiftlabs October 30, 2025 20:46
@byteshiftlabs byteshiftlabs marked this pull request as ready for review October 30, 2025 20:47
@byteshiftlabs byteshiftlabs merged commit eedc375 into feature/function_calls Oct 30, 2025
1 check passed
@byteshiftlabs byteshiftlabs deleted the copilot/sub-pr-7 branch October 30, 2025 20:47
byteshiftlabs added a commit that referenced this pull request Jan 9, 2026
Update documentation to reflect refactored parse_standalone_function_call implementation
byteshiftlabs added a commit that referenced this pull request Jan 9, 2026
Update documentation to reflect refactored parse_standalone_function_call implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants