Refactor: Extract shared function call argument parsing logic#8
Refactor: Extract shared function call argument parsing logic#8byteshiftlabs merged 5 commits intofeature/function_callsfrom
Conversation
Co-authored-by: cmelnu <35693456+cmelnu@users.noreply.github.com>
Co-authored-by: cmelnu <35693456+cmelnu@users.noreply.github.com>
Co-authored-by: cmelnu <35693456+cmelnu@users.noreply.github.com>
There was a problem hiding this comment.
@copilot Please, remove the _codeql_build_dir and every codeql related change
There was a problem hiding this comment.
Pull Request Overview
This PR refactors parser code to extract shared function call argument parsing logic into a common helper function, addressing code duplication between expression and statement contexts.
Key changes:
- Extracted common argument parsing logic into
parse_function_call_args() - Simplified
parse_function_call()to delegate to the shared helper - Updated
parse_standalone_function_call()to use the helper and add semicolon validation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@copilot remove all codeql changes (the folder, the files, etc) |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 169 out of 459 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: cmelnu <35693456+cmelnu@users.noreply.github.com>
All CodeQL changes have been removed in commit 650f0bb. This includes:
Removed all CodeQL build artifacts and the |
Refactor: Extract shared function call argument parsing logic
Refactor: Extract shared function call argument parsing logic
Summary
Successfully addressed the code duplication feedback by extracting common argument parsing logic into a shared
parse_function_call_args()helper function. This reduces code duplication by ~35 lines and improves maintainability.Removed all CodeQL build artifacts that were accidentally committed.
Security Summary
No security vulnerabilities found in the changes.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.