Skip to content

Comments

Refactor: Extract shared function call argument parsing logic#8

Merged
byteshiftlabs merged 5 commits intofeature/function_callsfrom
copilot/sub-pr-7
Oct 30, 2025
Merged

Refactor: Extract shared function call argument parsing logic#8
byteshiftlabs merged 5 commits intofeature/function_callsfrom
copilot/sub-pr-7

Conversation

Copy link
Contributor

Copilot AI commented Oct 30, 2025

  • Understand the code duplication between parse_function_call and parse_standalone_function_call
  • Create a shared helper function to parse function arguments
  • Update parse_function_call to use the shared helper
  • Update parse_standalone_function_call to use the shared helper
  • Build and test the changes
  • Run code review and security checks
  • Remove all CodeQL build artifacts per user request

Summary

Successfully addressed the code duplication feedback by extracting common argument parsing logic into a shared parse_function_call_args() helper function. This reduces code duplication by ~35 lines and improves maintainability.

Removed all CodeQL build artifacts that were accidentally committed.

Security Summary

No security vulnerabilities found in the changes.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits October 30, 2025 20:15
Co-authored-by: cmelnu <35693456+cmelnu@users.noreply.github.com>
Co-authored-by: cmelnu <35693456+cmelnu@users.noreply.github.com>
Co-authored-by: cmelnu <35693456+cmelnu@users.noreply.github.com>
Copilot AI changed the title [WIP] Update to address feedback on function call support Refactor: Extract shared function call argument parsing logic Oct 30, 2025
Copilot AI requested a review from byteshiftlabs October 30, 2025 20:19
@byteshiftlabs byteshiftlabs marked this pull request as ready for review October 30, 2025 20:20
@byteshiftlabs byteshiftlabs added the enhancement New feature or request label Oct 30, 2025
Copy link
Owner

@byteshiftlabs byteshiftlabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Please, remove the _codeql_build_dir and every codeql related change

@byteshiftlabs byteshiftlabs marked this pull request as draft October 30, 2025 20:27
@byteshiftlabs byteshiftlabs requested review from byteshiftlabs and Copilot and removed request for byteshiftlabs October 30, 2025 20:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors parser code to extract shared function call argument parsing logic into a common helper function, addressing code duplication between expression and statement contexts.

Key changes:

  • Extracted common argument parsing logic into parse_function_call_args()
  • Simplified parse_function_call() to delegate to the shared helper
  • Updated parse_standalone_function_call() to use the helper and add semicolon validation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@byteshiftlabs
Copy link
Owner

@copilot remove all codeql changes (the folder, the files, etc)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 169 out of 459 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: cmelnu <35693456+cmelnu@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Oct 30, 2025

@copilot remove all codeql changes (the folder, the files, etc)

All CodeQL changes have been removed in commit 650f0bb. This includes:

  • _codeql_build_dir/ directory and all its contents (455 files)
  • _codeql_detected_source_root symlink
  • Updated .gitignore to ignore these artifacts

@copilot Please, remove the _codeql_build_dir and every codeql related change

Removed all CodeQL build artifacts and the _codeql_detected_source_root symlink in commit 650f0bb. Also updated .gitignore to prevent these files from being committed in the future.

Copilot AI requested a review from byteshiftlabs October 30, 2025 20:38
@byteshiftlabs byteshiftlabs marked this pull request as ready for review October 30, 2025 20:39
@byteshiftlabs byteshiftlabs merged commit 05986c1 into feature/function_calls Oct 30, 2025
@byteshiftlabs byteshiftlabs deleted the copilot/sub-pr-7 branch October 30, 2025 20:39
byteshiftlabs added a commit that referenced this pull request Jan 9, 2026
Refactor: Extract shared function call argument parsing logic
byteshiftlabs added a commit that referenced this pull request Jan 9, 2026
Refactor: Extract shared function call argument parsing logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants