fix: use correct MIME type for SVG and JPG images #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a-dsp-websocket-test Feature/camilla dsp websocket test
Extract image data URL conversion to shared utility to avoid duplication. File extensions don't always match MIME types. Added a mapping for: - svg → image/svg+xml - jpg → image/jpeg
Contributor
|
will test the jpg variation. 👍 |
Idrimi
force-pushed
the
master
branch
2 times, most recently
from
4e63329 to
e81f427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed SVG images were not working (showing a broken image icon) in the album cover images:
Created a simple toImageDataUrl function that takes base64 data and an extension, and returns correctly MIME'd url data:
Most extensions will stay the same, except for;
Note; I haven't tested JPEG, since I don't have any streams that return a JPEG images. But
image/jpegis the official MIME type of JPEG images.Note 2; not sure why my Spotify stream always returns the logo instead of album cover, but that's probably an issue in the stream.
Tested by human.