This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Parse nulls in JSON (Also includes a couple of other fixes found in issues)#149
Open
h4dr0 wants to merge 3 commits intobradjasper:masterfrom
Open
Parse nulls in JSON (Also includes a couple of other fixes found in issues)#149h4dr0 wants to merge 3 commits intobradjasper:masterfrom
h4dr0 wants to merge 3 commits intobradjasper:masterfrom
Conversation
parse nulls fix + parse numbers as numeric
parse stringified numbers as numeric + don't substring truncate numbers (and thus keep numeric)
|
@h4dr0 thanks for the fix. I've just tested it and saw that you left sensitive(?) authentication data in the code https://github.com/bradjasper/ImportJSON/pull/149/files#diff-94c783fdb8e8c7bcdb536602ccdc3550R652 |
Author
|
Oops, not really sensitive as it only gave read-only access to product data
but I've revoked it anyway.
Thanks
…On Mon, 5 Oct 2020 at 14:57, Michael Birchler ***@***.***> wrote:
@h4dr0 <https://github.com/h4dr0> thanks for the fix. I've just tested it
and saw that you left sensitive(?) authentication data in the code
https://github.com/bradjasper/ImportJSON/pull/149/files#diff-94c783fdb8e8c7bcdb536602ccdc3550R652
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#149 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAUDIKLGKYZOJKFY3SCSSKDSJHGFDANCNFSM4KSFBYDQ>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parse nulls to prevent incorrect inheritance of values when property exists but is set to null in JSON