-
Notifications
You must be signed in to change notification settings - Fork 107
basic implementation of context-based path traction #1075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
basic implementation of context-based path traction #1075
Conversation
|
An automated preview of the documentation is available at https://1075.json.prtest2.cppalliance.org/libs/json/doc/html/index.html |
|
|
|
Is very interesting and clean. To move the Before the check, so we can capture the "last processed" json pointer |
|
This MR fulfills my needs -thank you for that- and I would be glad if it get merged at some point. But the CI fails for compilers other than GCC because it handles C++ variadic function in a different way. Other compilers treat them as C variadic function and complain that it Is there any way around that? Was this just a convenient way of forward declaring the |
| inline | ||
| void | ||
| tag_invoke(context_key_push_tag, string_view, ...) | ||
| { | ||
| } | ||
|
|
||
| inline | ||
| void | ||
| tag_invoke(context_key_pop_tag, ...) | ||
| { | ||
| } | ||
|
|
||
| inline | ||
| void | ||
| tag_invoke(context_index_push_tag, std::size_t, ...) | ||
| { | ||
| } | ||
|
|
||
| inline | ||
| void | ||
| tag_invoke(context_index_pop_tag, ...) | ||
| { | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was referring to these lines in the above comment.

Very rough draft of the idea.
For a context type Ctx the user is supposed to implement these functions:
The library would invoke them when traversing through the converted/parsed/serialized value.
Things to think about:
error_codein those callbacks.error_codein those functions. But then where would we get the results the calling function was supposed to create?