Skip to content

Conversation

@Darkness4
Copy link
Contributor

@Darkness4 Darkness4 commented Feb 10, 2026

🎟️ Tracking

Closes #6463
Closes PM-31597

πŸ“” Objective

Fix JSON parsing by removing comma, which caused passkeys to stop working on some browsers.

Regression introduced with #6299 (PM-30260).

Sorry if I shortcut some processes, but the fix is pretty short.

Tested on Fennec. If you close my PR to develop a long-term solution (adding some tests), I don't mind.

@Darkness4 Darkness4 requested review from a team and david-livefront as code owners February 10, 2026 02:53
@CLAassistant
Copy link

CLAassistant commented Feb 10, 2026

CLA assistant check
All committers have signed the CLA.

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-31980
Link: https://bitwarden.atlassian.net/browse/PM-31980

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

@Darkness4 Darkness4 changed the title Remove extra comma and fix JSON parsing Fix passkeys on community browsers by fixing JSON parsing Feb 10, 2026
@bitwarden-bot bitwarden-bot changed the title Fix passkeys on community browsers by fixing JSON parsing [PM-31980] Remove extra comma and fix JSON parsing Feb 10, 2026
@Darkness4 Darkness4 changed the title [PM-31980] Remove extra comma and fix JSON parsing [PM-31980] Fix passkeys on some browsers by fixing JSON parsing Feb 10, 2026
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details – 2d0bbd4a-e1bf-461b-82da-c13a2aa466f4

Great job! No new security vulnerabilities introduced in this pull request

@SaintPatrck SaintPatrck added this pull request to the merge queue Feb 10, 2026
@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 86.30%. Comparing base (4d31dcc) to head (ee69a69).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6502      +/-   ##
==========================================
- Coverage   86.36%   86.30%   -0.06%     
==========================================
  Files         767      780      +13     
  Lines       56045    56378     +333     
  Branches     8152     8154       +2     
==========================================
+ Hits        48405    48659     +254     
- Misses       4800     4879      +79     
  Partials     2840     2840              

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into bitwarden:main with commit f094430 Feb 10, 2026
14 of 16 checks passed
@Darkness4 Darkness4 deleted the chore/fix-passkey-community branch February 10, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[PM-31597] Passkeys stopped working on some browsers (beginning with Android app 2026.1.0)

4 participants