Run verify_msg before encoding#116
Open
luisguilhermemsalmeida wants to merge 4 commits intobitwalker:masterfrom
Open
Run verify_msg before encoding#116luisguilhermemsalmeida wants to merge 4 commits intobitwalker:masterfrom
luisguilhermemsalmeida wants to merge 4 commits intobitwalker:masterfrom
Conversation
Author
|
@bitwalker Did you have the time to take a look at this PR? Thanks! |
0a529f0 to
3abb06f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encoding integer values of out the specified range (overflow) results in an invalid binary which crashes the decoding in a way that is very hard to troubleshoot. It's best if the encoding fails with an easy message:
https://github.com/tomas-abrahamsson/gpb README file states: