[WIP] add ping method and auto-ping-pong#445
Open
cwolters wants to merge 5 commits intobitfinexcom:masterfrom
Open
[WIP] add ping method and auto-ping-pong#445cwolters wants to merge 5 commits intobitfinexcom:masterfrom
cwolters wants to merge 5 commits intobitfinexcom:masterfrom
Conversation
Contributor
|
Thanks for this; could you also add an If not I can do it, and would merge this in before, so let me know. Great idea overall. |
Contributor
Author
|
Hi Cris, I can do it, but it will take a few days before I can work on the topic. So let's keep this pull request and I will update it later. |
…check if the ws is still connected
…s an open connection
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a ping method and an auto-ping-pong operation to detect interrupted connections and allow auto-reconnect afterwads.
Added a simple ping operation to allow an easy ping/pong.
In case of no channel action (e.g. a single auth user where no messages are flying around), the ping/pong messages will keep the lib from reconnecting due to watchdog timeout..
Currently there is no auto-ping-pong build into the lib. You need to build it on top.
Would be a nice extension to the existing watchdog - so that it triggeres a reconnect only if no ping/pong comes through.