Conversation
bitschmidty
left a comment
bitschmidty
left a comment
There was a problem hiding this comment.
Concept ACK. Couple comments. Thanks much @yancyribbens , very cool.
Built, ran, and tested a few notebooks without issue. Im not a docker expert so cannot evaluate the docker file structure other than at a rudimentary level, but it worked right away for me!
| [path] | ||
| # Set this to the source directory for your Optech Taproot Bitcoin Core | ||
| # eg SOURCE_DIRECTORY=/Users/Optech/bitcoin | ||
| SOURCE_DIRECTORY= |
There was a problem hiding this comment.
Will want to keep this empty as default. Perhaps a note in the comment about this config for the docker setup?
There was a problem hiding this comment.
@bitschmidty I used a regex in the dockerfile to make this change during build:
RUN sed -i.bak 's\^SOURCE_DIRECTORY=\SOURCE_DIRECTORY=/optech/bitcoin\g' config.ini
Dockerfile
Outdated
| RUN ../dist/configure --disable-shared --enable-cxx --with-pic --prefix=$BDB_PREFIX | ||
| RUN make install | ||
|
|
||
| # install bitcoin 0.16.3 |
There was a problem hiding this comment.
Perhaps misleading since we are on the Optech Taproot_V0.1.4 branch
yancyribbens
force-pushed
the
add-docker-file
branch
2 times, most recently
from
1254b86 to
74aec8a
Compare
yancyribbens
force-pushed
the
add-docker-file
branch
from
74aec8a to
7e029d5
Compare
|
@bitschmidty updated based on your feedback. I also changed the maintainer label since I may not be able to provide ongoing support and maintenance. |
bitschmidty
left a comment
bitschmidty
left a comment
There was a problem hiding this comment.
ACK
Rebuilt, ran, and smoke tested a couple notebooks
|
Concept ACK. I plan to review this soon. Thanks for the contribution, @yancyribbens! |
3 participants
Add docker setup option for installing locally