Add weekly background Kyoto CBF sync task (#352)#354
Open
Aniket-pd wants to merge 1 commit intobitcoindevkit:mainfrom
Open
Add weekly background Kyoto CBF sync task (#352)#354Aniket-pd wants to merge 1 commit intobitcoindevkit:mainfrom
Aniket-pd wants to merge 1 commit intobitcoindevkit:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the background CBF sync flow discussed in #352.
In short, the app now registers a
BGProcessingTaskand schedules it to run roughly once a week (with network + external power requirements). When the task runs, it attempts to load the wallet and perform a Kyoto sync if the wallet exists and Kyoto is the selected backend.I also added the required
Info.plistentries for background processing and updated keychain accessibility to.afterFirstUnlockso background execution can still read wallet backup data while the device is locked.Notes to the reviewers
I kept this intentionally narrow to the core pieces needed for background sync:
I did not add product-level logging in this PR, since #351 tracks that separately.
Changelog notice
Add weekly background Kyoto CBF sync using
BGProcessingTask, including required background task configuration and keychain access changes needed for locked-device execution.Checklists
All Submissions:
.swift-formatfileNew Features:
Bugfixes: