Correct path and update version for ComputeCpp#32
Correct path and update version for ComputeCpp#32krikru wants to merge 4 commits intobenoitsteiner:masterfrom
Conversation
Added Tile, Transpose and Range Ops double support for SYCL device. Moved gpu_device_name() to test_util.py so now it can be used in force_gpu to pull either GPU or SYCL depending on what is available in the system.
- Registration of Type Traits required for stride slice op - Registration of ConcatOffset, _ListToArray, _ArrayToList Pad, Reverse ( CPU ), ReverseV2 ( CPU ), Size, ExpandDims, Squeeze, StridedSlice, StridedSliceGrad, StridedSliceAssign, TileGrad, InvertPermutation, Transpose - Registration of Sycl kernels only for essential data types - Floor_div_real has been disabled for SYCL device - Device in control_flow_ops_py_test.py needed to be lower cased
Conflicts: tensorflow/core/kernels/strided_slice_op_impl.h tensorflow/python/platform/test.py
This commit will: * Correct path to bin folder for ComputeCpp * Update ComputeCpp version from 0.1.1 to 0.1.2
| sudo cp -R ComputeCpp-CE-0.1.2-Linux /usr/local/computecpp | ||
| sudo chmod -R a+r /usr/local/computecpp/ | ||
| sudo chmod -R a+x /usr/local/computecpp/bin | ||
| sudo chmod -R a+x /usr/local/computecpp/ComputeCpp-CE-0.1.2-Linux/bin |
There was a problem hiding this comment.
We want to make the binaries we copied in from ComputeCpp-CE-0.1.2-Linux/bin to /usr/local/computecpp/bin executable. I think that the original path was therefore correct
There was a problem hiding this comment.
When I run
sudo chmod -R a+x /usr/local/computecpp/bin
I get
chmod: cannot access ‘/usr/local/computecpp/bin/’: No such file or directory
because the line
sudo cp -R ComputeCpp-CE-0.1.2-Linux /usr/local/computecpp
seems to copy the whole folder to /usr/local/computecpp, not just the folder contents (i.e. when I run ls /usr/local/computecpp I get ComputeCpp-CE-0.1.2-Linux, and the bin folder ends up in /usr/local/computecpp/ComputeCpp-CE-0.1.2-Linux).
There was a problem hiding this comment.
After second look, that command looks correct.
Although, the instructions in os_setup.md are correct when it comes to Ubuntu 14.04 and 16.04.
What is your OS?
EDIT:
Ok I found what the issue is
if we do:
sudo mkdir /usr/local/computecpp
we need to change:
sudo cp -R ComputeCpp-CE-0.1.2-Linux /usr/local/computecpp to
sudo cp -R ComputeCpp-CE-0.1.2-Linux/* /usr/local/computecpp
or simply remove folder creation step.
Fixed in #33
There was a problem hiding this comment.
Running the cp command with no prior computecpp folder worked better for me. I also believe that adding a "*" to the source file path in the cp command as you suggested would have worked if the computecpp folder would have been there when running it.
- Fixes documentation issue mentioned in benoitsteiner#32 (comment)
benoitsteiner
force-pushed
the
master
branch
2 times, most recently
from
b847171 to
f694daa
Compare
benoitsteiner
force-pushed
the
master
branch
from
57672d2 to
eb0d3a1
Compare
|
@krikru ping on this issue. |
|
The merge conflict in os_setup.md is resolved. Do you agree with the solution? |
|
Could you remove ComputeCpp-CE-0.1.2-Linux ? As per previous comments? |
|
Hm, it seems like GitHub keeps undoing my changes, or doesn't accept them, even though it indicates that the merge conflict in os_setup.md is successfully resolved when I press the "Resolve conflicts" button below, resolve the conflict and press "Mark as resolved." Do you know why that fails? |
3 participants
This commit will:
Correct path to bin folder for ComputeCpp
Update ComputeCpp version from 0.1.1 to 0.1.2