Fix propagation of global attributes to child datasets and variables #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
=======================================
Coverage 99.46% 99.46%
=======================================
Files 67 67
Lines 2810 2816 +6
Branches 413 413
=======================================
+ Hits 2795 2801 +6
Partials 15 15 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
forman
requested changes
Jan 23, 2026
Member
forman
left a comment
forman
left a comment
There was a problem hiding this comment.
Please fix:
- It is not clear, why the fix is correct. New code is also quite unintuitive.
- Missing unit tests
xrlint/_linter/apply.py
Outdated
Comment on lines
71
to
75
| dataset_copy = node.datatree.dataset.copy() | ||
| merged_dataset_attrs = { | ||
| **current_attrs, | ||
| **dataset_copy.attrs, | ||
| } |
Member
There was a problem hiding this comment.
This does not look right. Can you please add a comment explaining why this is done and why it is correct.
Also add a test case that verifies correctness and explains the use case / reproduces the issue.
xrlint/_linter/apply.py
Outdated
Comment on lines
93
to
96
| datatree_copy.attrs = { | ||
| **current_attrs, | ||
| **datatree_copy.attrs, | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the propagation of global DataTree attributes to child Datasets and Variables.
Closes #63.
Checklist (strike out non-applicable):
CHANGES.mdCHANGES.mddocs/*