Add map symmetry validation and tests#94
Open
stefangimmillaro wants to merge 1 commit intobattlecode:masterfrom
Open
Add map symmetry validation and tests#94stefangimmillaro wants to merge 1 commit intobattlecode:masterfrom
stefangimmillaro wants to merge 1 commit intobattlecode:masterfrom
Conversation
adds assertSymmetryValid to LiveMap for validating terrain and initial bodies against declared symmetry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed there is no live implementation for symmetry so I re-added it with this year's gameplay mechanics.
Gaps
I omitted the cat waypoints I think that can be a followup if anyone wants to do it.
Changes
engine/src/main/battlecode/world/LiveMap.javaadded the runtime checkengine/src/main/battlecode/world/MapBuilder.javaadded convenience testing methodsengine/src/test/battlecode/world/LiveMapTest.javaadded positive and negative static tests. added maps directory traversal test.I will happily address high impact feedback but would prefer to delegate small idiomatic differences and nitpicks to teh devs!