Open
Conversation
… still need to be deleted) and moved source files so that they use the standard Maven project layout.
…est dependency. Note: Tests are currently failing, need to figure out why.
…gnored as I'm not yet sure what's causing it to fail
…r which is also no longer used as dependencies are now resolved by Maven
Owner
|
Thanks but I have kind of abandoned this and will be releasing a wrapper around pegdown. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I wanted to use markdown-plus as a jar in my Groovy project but I noticed it doesn't exist in any Maven repo or as a binary .jar distribution. This got me thinking and I ended up mavenising the project. Thought I'd share my changes in case you were interested in pushing it to the Maven central repo so others can depend on markdown-plus Maven style?
The changes I have made are:
mvn clean installwill build the app jar, run the tests and build a .zip distribution which contains markdown-plus, all the required dependencies, the mdp bootstrap script and the templates folder.A couple of issues I have noticed:
Oh, finally I'm afraid I'm a bit of a Git novice, hopefully I've gotten everything right in terms of my commits and the pull request but let me know if something doesn't work for any reason.
Anyway, hope this is of some use to you.
Cheers,
Edd