Skip to content

feat(metering): use pending flashblocks state for bundle metering #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danyalprout merged 1 commit into from
Jan 13, 2026
Merged

feat(metering): use pending flashblocks state for bundle metering #387

danyalprout merged 1 commit into from
Jan 13, 2026

Conversation

@niran
Copy link
Contributor

@niran niran commented Jan 12, 2026 •
edited
Loading

Summary

Enable bundle metering to use the current pending flashblocks state instead of just the canonical block state. This ensures that bundle simulations see the same state that will be used when the bundle is actually included in a flashblock.

Changes

Metering Crate

  • meter.rs: Add PendingState struct containing BundleState and optional PendingTrieInput. Update meter_bundle to accept an optional PendingState parameter. Use with_bundle_prestate() to layer pending flashblock state on top of canonical state.
  • rpc.rs: Update MeteringApiImpl to integrate with flashblocks API. Get pending blocks state and pass it to meter_bundle. Include state_flashblock_index in response.
  • extension.rs: Update MeteringExtension to accept FlashblocksConfig for state access.
  • lib.rs: Export PendingState and PendingTrieInput.

Flashblocks Crate

  • state.rs: Add Default impl for FlashblocksState.
  • extension.rs: Add Clone derive to FlashblocksConfig.
  • tests/state.rs: Add integration tests verifying that bundle metering correctly sees pending flashblock state changes.

Architecture

Bundle Metering with Pending State:

┌─────────────────────────────────┐
│  State (bundle tracking)        │  ← Tracks bundle writes
│  with_bundle_prestate()         │  ← Includes flashblock state as prestate
├─────────────────────────────────┤
│  StateProviderDatabase          │  ← Reads from canonical chain state
└─────────────────────────────────┘

Test Plan

  • Bundle metering correctly fails for nonce=1 tx without flashblock state (canonical nonce is 0)
  • Bundle metering succeeds for nonce=1 tx with flashblock state showing pending nonce=1
  • State visibility tests pass
  • cargo +nightly clippy passes
  • cargo +nightly fmt passes

@niran niran force-pushed the niran/flashblocks-layering-fix branch from da51cc3 to 75e8eaf Compare January 12, 2026 20:03
@niran niran force-pushed the niran/meter-flashblocks-state-v2 branch from 994978c to 13ef63c Compare January 12, 2026 20:03
@danyalprout danyalprout added this to the v0.3.0 milestone Jan 12, 2026
@niran niran force-pushed the niran/meter-flashblocks-state-v2 branch from 13ef63c to 6817f24 Compare January 12, 2026 22:06
@niran niran force-pushed the niran/flashblocks-layering-fix branch from 75e8eaf to 0cba54d Compare January 13, 2026 00:58
@niran niran force-pushed the niran/meter-flashblocks-state-v2 branch from 6817f24 to 8dadef0 Compare January 13, 2026 00:58
@niran niran force-pushed the niran/flashblocks-layering-fix branch from 0cba54d to 8bca81f Compare January 13, 2026 01:22
@niran niran force-pushed the niran/meter-flashblocks-state-v2 branch 2 times, most recently from 724a0c9 to be1c7a5 Compare January 13, 2026 01:55
@niran niran force-pushed the niran/flashblocks-layering-fix branch from 8bca81f to 25c0260 Compare January 13, 2026 01:55
danyalprout
danyalprout reviewed Jan 13, 2026
View reviewed changes
Base automatically changed from niran/flashblocks-layering-fix to main January 13, 2026 02:30
@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 13, 2026 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@danyalprout danyalprout mentioned this pull request Jan 13, 2026
Merged
@niran niran force-pushed the niran/meter-flashblocks-state-v2 branch from be1c7a5 to f1a198a Compare January 13, 2026 17:43
@niran
Use pending flashblocks state for bundle metering
3e17305 
Add support for metering bundles against the current flashblocks pending
state instead of just the canonical block state. This ensures that bundle
simulations see the same state that will be used when the bundle is
actually included.

Key changes:
- Add FlashblocksState struct containing Cache and BundleState
- Update meter_bundle to accept optional FlashblocksState parameter
- Implement three-layer database architecture in metering
- Add integration tests for flashblock state visibility
@niran niran force-pushed the niran/meter-flashblocks-state-v2 branch from f1a198a to 3e17305 Compare January 13, 2026 18:01
@niran niran requested a review from danyalprout January 13, 2026 18:03
refcell
refcell approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@refcell refcell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me pending @danyalprout

danyalprout
danyalprout approved these changes Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@danyalprout danyalprout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! this looks great

@danyalprout danyalprout added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit fe8d4cd Jan 13, 2026
29 checks passed
@danyalprout danyalprout deleted the niran/meter-flashblocks-state-v2 branch January 13, 2026 18:44
niran added a commit that referenced this pull request Jan 13, 2026
@niran
feat(testing): add metering tests for state root and flashblock integ…
611c794 
…ration

Add new metering tests to verify the metering state root PR stack features:

- meter_bundle_with_transaction: Meters a real signed transaction and
  verifies gas usage, execution time, and result fields
- meter_bundle_flashblock_index: Verifies that state_flashblock_index
  is returned when metering uses flashblocks state
- meter_bundle_state_root_timing: Verifies state root timing with ETH transfer
- meter_bundle_state_root_timing_simulator: Verifies state root timing
  with Simulator contract for more meaningful results

Adds Simulator contract integration for controlled resource usage testing:
- Configurable storage creation (gas pressure)
- Configurable account creation (state root time pressure)

New CLI argument:
- --simulator: Address of deployed Simulator contract

These tests exercise the new MeterBundleResponse fields added in the
metering state root PR stack:
- state_flashblock_index (from PR #387)
- state_root_time_us (from PR #349)
niran added a commit that referenced this pull request Jan 13, 2026
@niran
feat(testing): add metering tests for state root and flashblock integ…
bd72005 
…ration

Add new metering tests to verify the metering state root PR stack features:

- meter_bundle_with_transaction: Meters a real signed transaction and
  verifies gas usage, execution time, and result fields
- meter_bundle_flashblock_index: Verifies that state_flashblock_index
  is returned when metering uses flashblocks state
- meter_bundle_state_root_timing: Verifies state root timing with ETH transfer
- meter_bundle_state_root_timing_simulator: Verifies state root timing
  with Simulator contract for more meaningful results

Adds Simulator contract integration for controlled resource usage testing:
- Configurable storage creation (gas pressure)
- Configurable account creation (state root time pressure)

New CLI argument:
- --simulator: Address of deployed Simulator contract

These tests exercise the new MeterBundleResponse fields added in the
metering state root PR stack:
- state_flashblock_index (from PR #387)
- state_root_time_us (from PR #349)
niran added a commit that referenced this pull request Jan 13, 2026
@niran
feat(testing): add metering tests for state root and flashblock integ…
e456503 
…ration

Add new metering tests to verify the metering state root PR stack features:

- meter_bundle_with_transaction: Meters a real signed transaction and
  verifies gas usage, execution time, and result fields
- meter_bundle_flashblock_index: Verifies that state_flashblock_index
  is returned when metering uses flashblocks state
- meter_bundle_state_root_timing: Verifies state root timing with ETH transfer
- meter_bundle_state_root_timing_simulator: Verifies state root timing
  with Simulator contract for more meaningful results

Adds Simulator contract integration for controlled resource usage testing:
- Configurable storage creation (gas pressure)
- Configurable account creation (state root time pressure)

New CLI argument:
- --simulator: Address of deployed Simulator contract

These tests exercise the new MeterBundleResponse fields added in the
metering state root PR stack:
- state_flashblock_index (from PR #387)
- state_root_time_us (from PR #349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danyalprout danyalprout danyalprout approved these changes

@refcell refcell refcell approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@niran @cb-heimdall @danyalprout @refcell