Fix commentstring and includeexpr aren't set in objc files#7
Open
idbrii wants to merge 1 commit intob4winckler:masterfrom
Open
Fix commentstring and includeexpr aren't set in objc files#7idbrii wants to merge 1 commit intob4winckler:masterfrom
idbrii wants to merge 1 commit intob4winckler:masterfrom
Conversation
Fix commentstring and includeexpr aren't set in objc files. Since we don't set did_ftplugin, the built-in objc.vim (invoked after user files) will overwrite our settings. We either need to set did_ftplugin (and do all the setup ourself) or do our modifications from after/. I suspect this used to work but vim's runtime files changed to explicitly set these variables. Test Check `:verb set commentstring?` after loading a .m file in macvim 8.2.1719.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move ftplugin to after directory.
Since we don't set did_ftplugin, the built-in objc.vim (invoked after
user files) will overwrite our settings. We either need to set
did_ftplugin (and do all the setup ourself) or do our modifications from
after/.
I suspect this used to work but vim's runtime files changed to
explicitly set these variables. but I haven't checked.
Test
Check
:verb set commentstring?after loading a .m file in macvim8.2.1719.
reprovimrc.vim