fix(serve/bedrock): robust S3 manifest lookup and improved error handling #5534
+215
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(serve/bedrock): robust S3 manifest lookup and improved error handling
Summary
Robust S3 manifest lookup and clearer S3 error handling for Bedrock Nova models.
Files Changed
Description of Changes
dirname/manifest.jsondirname/output/manifest.jsonparent/manifest.jsonClientError(botocore) where available to detect missing keys/buckets and continue searching.ValueErrorwhen a checkpoint cannot be located."checkpoint"), with fallback to common names:checkpoint_s3_bucketcheckpoint_s3_uricheckpoint_s3_pathImpact
Testing
test_bedrock_model_builder.py(two tests).Review Notes
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.