Conversation
AntoniaSzecsi
changed the title
M-Elsaeed
approved these changes
Sep 4, 2025
maxday
reviewed
Sep 4, 2025
Dockerfile.rie
Outdated
| @@ -0,0 +1,16 @@ | |||
| FROM public.ecr.aws/lambda/ruby:3.2 | |||
maxday
reviewed
Sep 4, 2025
| COPY . ${LAMBDA_TASK_ROOT}/ | ||
| WORKDIR ${LAMBDA_TASK_ROOT} | ||
|
|
||
| # Build and install the RIC gem |
Member
There was a problem hiding this comment.
should we uninstall the previous gem just to be sure we're starting from a clean state?
Contributor
Author
There was a problem hiding this comment.
You are right, it's a good practice
maxday
reviewed
Sep 4, 2025
Dockerfile.rie
Outdated
| @@ -0,0 +1,19 @@ | |||
| FROM public.ecr.aws/lambda/ruby:3.3.2025.08.26.15 | |||
Member
There was a problem hiding this comment.
let's use public.ecr.aws/lambda/ruby:3.3 as this tag will be overiden every time we will release a new image for 3.3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR removes the broken docker-compose template that referenced missing ../docker-helpers/ files and implements a simple approach for testing local RIC changes.
Changes:
Target (OCI, Managed Runtime, both):
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.