NIFs: fix bug in erlang:fun_info/2 #2095
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pguyot
approved these changes
Feb 11, 2026
Collaborator
pguyot
left a comment
pguyot
left a comment
There was a problem hiding this comment.
clang-format needs to be made happy but otherwise it's great.
Also I wouldn't call it a "potential" bug, it's just a bug.
bettio
changed the title
`memory_ensure_free_with_roots(..., 2, (term[]){ key, value }, ...)` is
a bad pattern.
In this example, after GC, roots should be read since `key` and `value` now
may point to invalid terms, but that anonymous array cannot be accessed,
so actual `key` and `value` cannot be read.
Signed-off-by: Davide Bettio <davide@uninstall.it>
bettio
force-pushed
the
fix-erlang-fun_info-bug
branch
from
c22334f to
292e1d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memory_ensure_free_with_roots(..., 2, (term[]){ key, value }, ...)is a bad pattern.In this example, after GC, roots should be read since
keyandvaluenow may point to invalid terms, but that anonymous array cannot be accessed, so actualkeyandvaluecannot be read.These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later