Support for comparison of functions#2085
Conversation
c30e345 to
395f800
Compare
bettio
left a comment
There was a problem hiding this comment.
I think it is mostly ok, just a few minor changes:
- Few more tests should be added so we test all cases.
- I suggest moving the function block just after TERM_TYPE_INDEX_REFERENCE block
src/libAtomVM/term.c
Outdated
| } | ||
| } | ||
| default: | ||
| case TERM_TYPE_INDEX_FUNCTION: |
There was a problem hiding this comment.
Let's move this entire block of code between TERM_TYPE_INDEX_REFERENCE and TERM_TYPE_INDEX_PORT, so we follow TermTypeIndex ordering:
[...]
TERM_TYPE_INDEX_ATOM = 3,
TERM_TYPE_INDEX_REFERENCE = 4,
TERM_TYPE_INDEX_FUNCTION = 5,
TERM_TYPE_INDEX_PORT = 6,
TERM_TYPE_INDEX_PID = 7,
[...]There was a problem hiding this comment.
I moved it just after TERM_TYPE_INDEX_REFERENCE, but the order is not followed for other indices
75dfd2d to
de2f176
Compare
|
Awesome, let's rebase & fixup everything into a single commit and it can be merged. I'll do a last CI run in the meanwhile. |
Signed-off-by: Mateusz Front <mateusz.front@swmansion.com>
de2f176 to
c4978bf
Compare
|
Squashed into a single commit. BTW, Github supports squash&merge, maybe worth using that instead of squashing manually each time |
Quite yes, works well unless you sign your commits. |
|
eh okay... |
These changes are made under both the "Apache 2.0" and the "GNU Lesser General
Public License 2.1 or later" license terms (dual license).
SPDX-License-Identifier: Apache-2.0 OR LGPL-2.1-or-later