wip: add get_validate_value_or_guard_async#80
Draft
xldenis wants to merge 1 commit intoarthurprs:masterfrom
Draft
wip: add get_validate_value_or_guard_async#80xldenis wants to merge 1 commit intoarthurprs:masterfrom
xldenis wants to merge 1 commit intoarthurprs:masterfrom
Conversation
Author
|
I've been thinking about the semantics of this, and I think there's footgun in it currently. If multiple tasks call this api with different validation functions there's no guarantee that when you resume you have a value that will satisfy your validation function. This feels like it could easily lead to bugs, the only fix I can think of is that one of the waked tasks should get a placeholder and try inserting a new value. |
Owner
|
Your concern makes sense. Hand-wavely, another option may be to hide the generic guard from the validation callers (e.g. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a solution to #73, introducing a
get_validate_or_guard_asyncmethod which allows passing a validation function to determine whether we should consider the currently inserted value as 'live'. If the value fails validation it will be replaced with aPlaceholderand the guard returned.todo: