toggle the logging from command line#19
toggle the logging from command line#19pearlfranz20 wants to merge 1 commit intoapprenticelearner:masterfrom
Conversation
toggle logging with debugging flags
| parser.add_argument('--outer-loop-url', default=None, dest="outer_loop_url", metavar="<outer_loop_url>", | ||
| help="Specifies the URL of a running outer loop server.") | ||
| parser.add_argument('--debug', action='store_true', help="Makes logging messages visible in the console.") | ||
| parser.add_argument('--debug-agent', action='store_true', dest="debug_agent", help="Makes logging messages for the agent visible in the console.") |
There was a problem hiding this comment.
I don't think its a good idea to constantly add new flags for different debuggers like this. There are many more instances of the logging module used throughout AL_Core that would not respond to this style of flagging. A more general solution where you provide some kind of delimited list that switches on multiple loggers at once seems like the ideal in this case.
| help="Specifies the directory of the outer loop repo.") | ||
| parser.add_argument('--outer-loop-url', default=None, dest="outer_loop_url", metavar="<outer_loop_url>", | ||
| help="Specifies the URL of a running outer loop server.") | ||
| parser.add_argument('--debug', action='store_true', help="Makes logging messages visible in the console.") |
There was a problem hiding this comment.
How is the behavior of this flag different form other debugging flags? It seems like this one corresponds to debugging in the host_server specifically. Can it be given a more descriptive name? Alternatively, see my other comment that it could maybe be part of a delimited list of loggers to activate.
eharpste
left a comment
eharpste
left a comment
There was a problem hiding this comment.
Similar to my comment on AL_Core, I think we want to design a more comprehensive solution to this logging problem. I will start an issue on the other repo for this.
|
See AL_Core/#79 for more discussion on this idea. |
2 participants
toggle logging with debugging flags