feat(rust/sedona-spatial-join) Making SpatialIndex a trait#645
Open
pwrliang wants to merge 3 commits intoapache:mainfrom
Open
feat(rust/sedona-spatial-join) Making SpatialIndex a trait#645pwrliang wants to merge 3 commits intoapache:mainfrom
pwrliang wants to merge 3 commits intoapache:mainfrom
Conversation
pwrliang
force-pushed
the
spatial-index-trait
branch
from
dcab75a to
085a047
Compare
Kontinuation
approved these changes
Feb 20, 2026
Member
Kontinuation
left a comment
Kontinuation
left a comment
There was a problem hiding this comment.
The refactoring for SpatialIndex looks good to me. BTW, I believe that SpatialIndexBuilder also need to be a trait.
| self.probe_threads_counter.fetch_sub(1, Ordering::Relaxed) == 1 | ||
| } | ||
|
|
||
| fn report_probe_completed(&self) -> bool; |
Member
There was a problem hiding this comment.
We can do another pass of refactoring to move probe completion markers out of spatial index, this will simplify the interface of SpatialIndex. This does not need to be done in this PR.
Member
|
Thank you for opening! I'm happy to take a look after the 0.3.0 release branch is created (hopefully Monday!). |
pwrliang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits
SpatialIndexinto a SpatialIndex trait and a default implementationDefaultSpatialIndex. These changes are for the upcoming GPU-based spatial join.