Skip to content

Revert name change in required tests #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micafer merged 1 commit into from
Jan 26, 2026
Merged

Revert name change in required tests #2095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .asf.yaml
View file
Open in desktop
Copy link
Member

@tisonkun tisonkun Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may even keep the version-less one and drop python version in name. This way, when we bump toolchain the next time, we don't need to work around it again.

Copy link
Contributor Author

@micafer micafer Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it seems that if you use a matrix, the value of the item in the matrix will be always appended so, we should remove the matrix from the tasks

Copy link
Member

@tisonkun tisonkun Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It seems the matrix has always only one argument and we can inline it.

If there is a real matrix, we can use an aggregation trick like https://github.com/fast/logforth/blob/7cad34bdc63a9692040143497ddbf346f5d10264/.github/workflows/ci.yml#L108-L124

Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ github:
- "Unit Tests (Python 3.12)"
- "Unit Tests (Python 3.13)"
- "Dependency Review"
- "Run Various Lint and Other Checks"
- "Build and upload Documentation"
- "Run Various Lint and Other Checks (3.10)"
- "Build and upload Documentation (3.10)"

notifications:
jobs: notifications@libcloud.apache.org
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,3 +436,15 @@ jobs:
run: |
python -m pip install requests
python ./contrib/trigger_rtd_build.py

old_check_name:
name: Build and upload Documentation
runs-on: ubuntu-latest
steps:
- run: echo "OK"

old_check_name_2:
name: Run Various Lint and Other Checks
runs-on: ubuntu-latest
steps:
- run: echo "OK"