Fix wheel extension in verify_checksums.sh #2092
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #2092 +/- ##
=======================================
Coverage 83.34% 83.34%
=======================================
Files 353 353
Lines 81769 81769
Branches 8993 8993
=======================================
Hits 68148 68148
Misses 10796 10796
Partials 2825 2825 🚀 New features to boost your workflow:
|
Contributor
Author
|
I detected another issue getting the wheel from the pypi repo. Also fixed now. |
Contributor
Author
|
Hi @PsiACE and @tisonkun, this change: 0a37446#diff-b4c2a69650f9ac84008ad9f745859a645c9466350ffdfe5f919655039ee2e2c3L51 has set an incorrect name in the tests, so I cannot merge this change (where I revert this change). How could we fix this? |
Member
|
I can we can drop python version name in the status. It's meaningless as well. Let me try to prepare a fix. |
Contributor
Author
|
I alredy make a fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wheel extension in verify_checksums.sh
Description
Verify Artifacts Checksum are failing due to an incorrect wheel file name, it uses
-py3-none-any.whlextension instead of the current-py2.py3-none-any.whl(see: https://downloads.apache.org/libcloud/)Status
Checklist (tick everything that applies)