Skip to content

Fix process of restore external-service instance #17194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JackieTien97 merged 1 commit into from
Feb 10, 2026
Merged

Fix process of restore external-service instance #17194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 16 additions & 26 deletions ...in/java/org/apache/iotdb/db/service/externalservice/ExternalServiceManagementService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
import javax.annotation.concurrent.GuardedBy;

import java.io.IOException;
import java.lang.reflect.InvocationTargetException;
import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
Expand Down Expand Up @@ -192,20 +191,14 @@ private IExternalService createExternalServiceInstance(String serviceName, Strin
ExternalServiceClassLoader classLoader = new ExternalServiceClassLoader(libRoot);
return (IExternalService)
Class.forName(className, true, classLoader).getDeclaredConstructor().newInstance();
} catch (IOException
| InstantiationException
| InvocationTargetException
| NoSuchMethodException
| IllegalAccessException
| ClassNotFoundException
| ClassCastException e) {
} catch (Throwable t) {
TSStatus status =
new TSStatus(TSStatusCode.EXTERNAL_SERVICE_INSTANCE_CREATE_ERROR.getStatusCode());
status.setMessage(
String.format(
"Failed to start External Service %s, because its instance can not be constructed successfully. Exception: %s",
serviceName, e));
LOGGER.warn(status.getMessage(), e);
serviceName, t));
LOGGER.warn(status.getMessage(), t);
throw new ExternalServiceManagementException(status);
}
}
Expand Down Expand Up @@ -330,20 +323,13 @@ public void restoreRunningServiceInstance() {
serviceInfo -> {
// start services with RUNNING state
if (serviceInfo.getState() == RUNNING) {

try {
IExternalService serviceInstance =
createExternalServiceInstance(
serviceInfo.getServiceName(), serviceInfo.getClassName());
checkState(serviceInstance != null, INSTANCE_NULL_ERROR_MSG);
serviceInfo.setServiceInstance(serviceInstance);
serviceInstance.start();
} finally {
// set STOPPED to avoid the case: service is RUNNING, but its instance is null
if (serviceInfo.getServiceInstance() == null) {
serviceInfo.setState(STOPPED);
}
}
IExternalService serviceInstance =
createExternalServiceInstance(
serviceInfo.getServiceName(), serviceInfo.getClassName());
checkState(
serviceInstance != null, INSTANCE_NULL_ERROR_MSG, serviceInfo.getServiceName());
serviceInfo.setServiceInstance(serviceInstance);
serviceInstance.start();
}
});
}
Expand All @@ -356,8 +342,12 @@ public void stopRunningServices() {
// stop services with RUNNING state
if (serviceInfo.getState() == RUNNING) {
IExternalService serviceInstance = serviceInfo.getServiceInstance();
checkState(serviceInstance != null, INSTANCE_NULL_ERROR_MSG);
serviceInstance.stop();
// serviceInstance maybe null when an exception occurs during the start of certain
// service in restoreRunningServiceInstance method
if (serviceInstance != null) {
// only stop the instance successfully started
serviceInstance.stop();
}
}
});
}
Expand Down