-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix typo: AGGREGRATE_TIME_LIST → AGGREGATE_TIME_LIST #17171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Fixes apache#17155 - AbstractCli.java: Rename constant from AGGREGRATE_TIME_LIST to AGGREGATE_TIME_LIST - Cli.java: Update all references to use correct spelling Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this is your first pull request in IoTDB project. Thanks for your contribution! IoTDB will be better because of you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a spelling typo in a constant name, changing AGGREGRATE_TIME_LIST to AGGREGATE_TIME_LIST throughout the CLI codebase. The typo was correctly identified in issue #17155, and this change ensures the constant name properly reflects its purpose of storing time aggregation operations.
Changes:
- Renamed the constant from
AGGREGRATE_TIME_LISTtoAGGREGATE_TIME_LIST(fixing the misspelling of "aggregate") - Updated all usages of the constant in the codebase
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| AbstractCli.java | Renamed the constant definition from AGGREGRATE_TIME_LIST to AGGREGATE_TIME_LIST |
| Cli.java | Updated both references (lines 188, 203) to use the corrected constant name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Good catch! You're right - I checked and this list is only written to but never read anywhere. It's dead code. I'll update this PR to remove the variable entirely instead of just fixing the typo. Thanks for the review! |
Per review feedback from @HTHou: this list is only written to but never read anywhere in the codebase - it's dead code. Removing it entirely instead of just fixing the typo. Fixes apache#17155
Hi @HTHou, I had already opened this issue and marked my interest in working on it. However, I noticed that @PDGGK submitted a PR without prior discussion or assignment. @PDGGK, could you please consider closing this PR so the contribution process remains fair and organized? Thank you for your understanding. |

Summary
Fix typo in constant name:
AGGREGRATE_TIME_LIST→AGGREGATE_TIME_LISTFixes #17155
Changes
AbstractCli.java: Rename constant fromAGGREGRATE_TIME_LISTtoAGGREGATE_TIME_LISTCli.java: Update all references (lines 188, 203) to use correct spellingNotes
🤖 Generated with Claude Code