Consolidating InMemoryCatalog and SqlCatalog tests #2906
+1,360
−2,096
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2870
Rationale for this change
Eliminates code duplication between
test_base.pyandtest_sql.pyby consolidating shared catalog behavior tests into a single parameterized test suite. This ensures consistent behavior testing across both catalog implementations and makes it easier to add new catalog implementations with shared test coverage.Changes
tests/catalog/test_catalog_behaviors.pywith parameterized tests covering both catalogstests/conftest.pytest_base.pyto InMemoryCatalog-specific teststest_sql.pyto SqlCatalog-specific teststest_partition_specfixture intests/conftest.pytests/table/test_upsert.pyAre these changes tested?
make testran successfully locallyAre there any user-facing changes?
No