Allow pre-set custom ExchangeId in HttpClientContext before request #788
+114
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rschmitt
requested changes
Jan 16, 2026
Comment on lines
+463
to
+480
| /** | ||
| * @since 5.1 | ||
| */ | ||
| public void setExchangeId(final String exchangeId) { | ||
| this.exchangeId = exchangeId; | ||
| } | ||
|
|
||
| /** | ||
| * @since 5.7 | ||
| */ | ||
| public String setExchangeId(final Supplier<String> supplier) { | ||
| final String exchangeId = this.exchangeId; // avoid getfield opcode | ||
| if (exchangeId == null) { | ||
| return this.exchangeId = supplier.get(); | ||
| } else { | ||
| return exchangeId; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
This looks incoherent. I'd expect the client builders to simply take a Supplier<String> exchangeIdSupplier, which defaults to ExecSupport::getNextExchangeId. The context classes shouldn't need to know about what supplies the exchange IDs, they should just know the exchange ID for the particular exchange they represent.
Contributor
There was a problem hiding this comment.
Also, there should be a documented contract for custom exchange ID suppliers, i.e. they must return a unique, non-null, non-blank string every time they are called.
Contributor
Author
There was a problem hiding this comment.
You're right. I'll refactor the implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for users to pre-set custom ExchangeId in HttpClientContext before request execution.
This enhancement enables better traceability and request correlation in distributed systems by allowing users to define their own exchange identifiers prior to request execution.