Skip to content

Conversation

@Jaehui-Lee
Copy link
Contributor

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

@Apache-HBase

This comment has been minimized.

Copy link
Contributor

@Apache9 Apache9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me I prefer we introduce a new configuration which indicates the bloom filter implementation? The current BloomType just indicates that how we want to apply the bloom filter, not the implementation of the bloom filter itself.

@Jaehui-Lee
Copy link
Contributor Author

For me I prefer we introduce a new configuration which indicates the bloom filter implementation? The current BloomType just indicates that how we want to apply the bloom filter, not the implementation of the bloom filter itself.

@Apache9

Thank you for the review! I've added a new BloomFilterImpl enum (BLOOM/RIBBON) separate from BloomType, with per-table (BLOOMFILTER_IMPL) and global (io.storefile.bloom.filter.impl) configuration support.

@Apache-HBase

This comment has been minimized.

@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 11s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+0 🆗 shelldocs 0m 0s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 37s master passed
+1 💚 compile 6m 39s master passed
+1 💚 checkstyle 1m 48s master passed
+1 💚 spotbugs 8m 38s master passed
+0 🆗 refguide 1m 41s branch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 spotless 0m 41s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for patch
+1 💚 mvninstall 2m 20s the patch passed
+1 💚 compile 6m 37s the patch passed
+1 💚 javac 6m 37s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 1m 46s the patch passed
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 spotbugs 9m 5s the patch passed
+0 🆗 refguide 1m 34s patch has no errors when building the reference guide. See footer for rendered docs, which you should manually inspect.
+1 💚 hadoopcheck 8m 47s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 0m 35s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 31s The patch does not generate ASF License warnings.
60m 9s
Subsystem Report/Notes
Docker ClientAPI=1.53 ServerAPI=1.53 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7653/5/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7653
Optional Tests dupname asflicense codespell detsecrets shellcheck shelldocs spotless javac spotbugs checkstyle compile hadoopcheck hbaseanti refguide
uname Linux 17bd3bc06920 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5d216c6
Default Java Eclipse Adoptium-17.0.11+9
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-7653/5/yetus-general-check/output/branch-site/book.html
refguide https://nightlies.apache.org/hbase/HBase-PreCommit-GitHub-PR/PR-7653/5/yetus-general-check/output/patch-site/book.html
Max. process+thread count 190 (vs. ulimit of 30000)
modules C: hbase-client hbase-server hbase-thrift . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7653/5/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 shellcheck=0.8.0
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 11s Docker mode activated.
-0 ⚠️ yetus 0m 4s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+0 🆗 mvndep 0m 11s Maven dependency ordering for branch
+1 💚 mvninstall 2m 30s master passed
+1 💚 compile 1m 40s master passed
+1 💚 javadoc 2m 28s master passed
+1 💚 shadedjars 4m 24s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 10s Maven dependency ordering for patch
+1 💚 mvninstall 2m 15s the patch passed
+1 💚 compile 1m 39s the patch passed
+1 💚 javac 1m 39s the patch passed
+1 💚 javadoc 2m 24s the patch passed
+1 💚 shadedjars 4m 21s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
-1 ❌ unit 226m 5s /patch-unit-root.txt root in the patch failed.
253m 30s
Subsystem Report/Notes
Docker ClientAPI=1.52 ServerAPI=1.52 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7653/5/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7653
Optional Tests javac javadoc unit compile shadedjars
uname Linux 67fc80569e63 6.14.0-1018-aws #18~24.04.1-Ubuntu SMP Mon Nov 24 19:46:27 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / 5d216c6
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7653/5/testReport/
Max. process+thread count 5937 (vs. ulimit of 30000)
modules C: hbase-client hbase-server hbase-thrift . U: .
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7653/5/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants