Skip to content

HBASE-29457 thrift1/DemoClient.py is not running #7529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
liuxiaocs7 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

HBASE-29457 thrift1/DemoClient.py is not running #7529

liuxiaocs7 wants to merge 5 commits into from
+243 −212

Conversation

@liuxiaocs7
Copy link
Contributor

@liuxiaocs7 liuxiaocs7 commented Dec 7, 2025

@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase

This comment has been minimized.

Sign in to view
@liuxiaocs7
Copy link
Contributor Author

liuxiaocs7 commented Dec 18, 2025

Hi, @guluo2016, could you be able to take a look at this PR in your spare time, thanks!

@guluo2016 guluo2016 self-requested a review January 11, 2026 14:32
guluo2016
guluo2016 reviewed Jan 13, 2026
View reviewed changes
hbase-examples/src/main/python/thrift1/DemoClient.py Outdated
demo_table, row, "entry:num".encode(), 10, dummy_attributes
)
printVersions(row, versions)
if len(versions) == 0:
Copy link
Member

@guluo2016 guluo2016 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old code is if len(versions) != 3: in here，which seems to be correct.
Is it necessary to change this?

Copy link
Contributor Author

@liuxiaocs7 liuxiaocs7 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @guluo2016, thank you for the review and sorry for the late reply. Yes, you're right, this change was made to align with the logic in Java, which we can see here. How do you suggest we handle this better, thanks!

Copy link
Member

@guluo2016 guluo2016 Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that if len(versions) != 3: is better
Because the code can indicate that the number of data versions is 3
What do you think?

Copy link
Contributor Author

@liuxiaocs7 liuxiaocs7 Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @guluo2016, thank you for your patient explanation, agree with your suggestion, i'll update this pr later, thanks!

@Apache-HBase
Copy link

Apache-HBase commented Jan 23, 2026

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 32s Docker mode activated.
-0 ⚠️ yetus 0m 3s Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck
_ Prechecks _
_ master Compile Tests _
+1 💚 mvninstall 3m 14s master passed
+1 💚 compile 0m 18s master passed
+1 💚 javadoc 0m 17s master passed
+1 💚 shadedjars 5m 40s branch has no errors when building our shaded downstream artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 0s the patch passed
+1 💚 compile 0m 19s the patch passed
+1 💚 javac 0m 19s the patch passed
+1 💚 javadoc 0m 15s the patch passed
+1 💚 shadedjars 5m 43s patch has no errors when building our shaded downstream artifacts.
_ Other Tests _
+1 💚 unit 1m 53s hbase-examples in the patch passed.
22m 14s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7529/4/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile
GITHUB PR #7529
Optional Tests javac javadoc unit compile shadedjars
uname Linux 6c3fc7dada57 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ba8b608
Default Java Eclipse Adoptium-17.0.11+9
Test Results https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7529/4/testReport/
Max. process+thread count 1643 (vs. ulimit of 30000)
modules C: hbase-examples U: hbase-examples
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7529/4/console
versions git=2.34.1 maven=3.9.8
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

@Apache-HBase
Copy link

Apache-HBase commented Jan 23, 2026

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 29s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
_ master Compile Tests _
+1 💚 mvninstall 3m 28s master passed
+1 💚 compile 0m 27s master passed
+1 💚 checkstyle 0m 11s master passed
+1 💚 spotbugs 0m 31s master passed
+1 💚 spotless 0m 51s branch has no errors when running spotless:check.
_ Patch Compile Tests _
+1 💚 mvninstall 3m 8s the patch passed
+1 💚 compile 0m 26s the patch passed
+1 💚 javac 0m 26s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 0m 11s the patch passed
+1 💚 pylint 0m 6s The patch generated 0 new + 13 unchanged - 3 fixed = 13 total (was 16)
+1 💚 spotbugs 0m 37s the patch passed
+1 💚 hadoopcheck 12m 10s Patch does not cause any errors with Hadoop 3.3.6 3.4.1.
+1 💚 spotless 0m 46s patch has no errors when running spotless:check.
_ Other Tests _
+1 💚 asflicense 0m 10s The patch does not generate ASF License warnings.
31m 19s
Subsystem Report/Notes
Docker ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7529/4/artifact/yetus-general-check/output/Dockerfile
GITHUB PR #7529
Optional Tests dupname asflicense javac spotbugs checkstyle codespell detsecrets compile hadoopcheck hbaseanti spotless pylint
uname Linux 45cfe2947322 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/hbase-personality.sh
git revision master / ba8b608
Default Java Eclipse Adoptium-17.0.11+9
Max. process+thread count 84 (vs. ulimit of 30000)
modules C: hbase-examples U: hbase-examples
Console output https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-7529/4/console
versions git=2.34.1 maven=3.9.8 spotbugs=4.7.3 pylint=2.15.5
Powered by Apache Yetus 0.15.0 https://yetus.apache.org

This message was automatically generated.

guluo2016
guluo2016 approved these changes Jan 23, 2026
View reviewed changes
Copy link
Member

@guluo2016 guluo2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guluo2016 guluo2016 guluo2016 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liuxiaocs7 @Apache-HBase @guluo2016