-
Notifications
You must be signed in to change notification settings - Fork 687
Snowflake: add Snowflake multi table insert support & add support for sample in subquery #2148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
finchxxia
wants to merge
9
commits into
apache:main
Choose a base branch
from
finchxxia:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+690
−4
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
426cc01
[Feature] add Snowflake multi table insert support
finchxxia ace189b
Merge branch 'main' into main
finchxxia 5150514
Add Snowflake multi-table INSERT support
finchxxia 607aad4
Merge branch 'main' into feature/snowflake-multi-table-insert-v2
finchxxia 5963d9d
Merge pull request #1 from finchxxia/feature/snowflake-multi-table-in…
finchxxia 6aab6ec
Update spans.rs
finchxxia 9d28b6a
Update sqlparser_common.rs
finchxxia 5e7aca1
Update query.rs
finchxxia 27c3453
Update mod.rs
finchxxia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we would need to merge this logic with the rest of the function, instead vs having a clause that is dedicated to the multi_table mode currently? with the latter is unclear how much is covered by the clause vs the rest of the statement and whether we could end up with incorrect formatting as a result. essentially that we update the current function at the points where we have new entries to display