support change ownship for SelectiveChannel #3198
Open
+25
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM |
chenBright
reviewed
Jan 17, 2026
Comment on lines
+72
to
+84
| int AddChannel(ChannelBase* sub_channel, ChannelHandle* handle) { | ||
| return AddChannel(sub_channel, "", OWNS_CHANNEL, handle); | ||
| } | ||
| int AddChannel(ChannelBase* sub_channel, const std::string& tag, | ||
| ChannelHandle* handle) { | ||
| return AddChannel(sub_channel, tag, OWNS_CHANNEL, handle); | ||
| } | ||
| int AddChannel(ChannelBase* sub_channel, ChannelOwnership ownership, | ||
| ChannelHandle* handle) { | ||
| return AddChannel(sub_channel, "", ownership, handle); | ||
| } | ||
| int AddChannel(ChannelBase* sub_channel, const std::string& tag, | ||
| ChannelOwnership ownership, ChannelHandle* handle); |
Contributor
There was a problem hiding this comment.
I think AddChannel has a combinatorial explosion problem.
int AddChannel(SelectiveChannel::SubChannelOptions);Using the SubChannelOptions overloaded AddChannel function would be more suitable, as it offers better extensibility.
In the meantime, please update the comments for the AddChannel function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
Problem Summary:
What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: