ARTEMIS-5861 use timeout when closing Netty ChannelGroups #6197
Conversation
jbertram
force-pushed
the
ARTEMIS-5861
branch
from
0ed49c2 to
0d3a4d9
Compare
|
|
||
| public static final boolean DEFAULT_WEB_SOCKET_COMPRESSION_SUPPORTED = false; | ||
|
|
||
| public static final String QUIET_PERIOD = "quietPeriod"; |
There was a problem hiding this comment.
did you really need this change? if not can you amend the commit without it please?
There was a problem hiding this comment.
Strictly speaking the change wasn't necessary. I changed it so that the order of QUIET_PERIOD & DEFAULT_QUIET_PERIOD matched that of SHUTDOWN_TIMEOUT & DEFAULT_SHUTDOWN_TIMEOUT. The change is really for readability and aesthetics, but I'll take it out and push a separate commit for it.
|
only asked a nit-pic. other than that if tests are good.. LGTM |
jbertram
force-pushed
the
ARTEMIS-5861
branch
from
0d3a4d9 to
0c319f8
Compare
|
The full test-suite looks good on this. |
There was a problem hiding this comment.
The full test suite is actually showing a problem, with another test, following this change and so now has a repeatable failure.
The system property fallback (separate issue noted around docs for that) this now uses for the acceptor channel group shutdown was already being set to 0 in the test suite, causing it not to wait for channel group shutdown now, and so likely regularly log the warning. There is a test checking for the presence of no warnings during cluster node restart,
ClusterCleanNodeShutdownTest.testNoWarningErrorsDuringRestartingNodesInCluster, and so that now fails repeatedly as a result of warnings about channel group shutdown.
| This is only valid for acceptors. | ||
| It is the number of milliseconds the broker will wait when shutting down each of the various Netty `ChannelGroup` instances as well as the `EventLoopGroup` instance associated with the acceptor. | ||
| The default is `3000`. | ||
| The default can also be set with the Java system property `DEFAULT_SHUTDOWN_TIMEOUT`. |
There was a problem hiding this comment.
This doesnt look to be accurate, the system property that is being inspected has a class name prefix, so it looks to actually be:
org.apache.activemq.artemis.core.remoting.impl.netty.TransportConstants.DEFAULT_SHUTDOWN_TIMEOUT
4 participants
No description provided.