GH-939: Remove reflection for gRPC buffers #954
+314
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e109e2c.
xborder
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
This comment has been minimized.
This comment has been minimized.
xborder
changed the title
lidavidm
reviewed
Jan 12, 2026
Comment on lines
463
to
466
| if (detachedByteBuffer == null || !detachedByteBuffer.isDirect()) { | ||
| closeQuietly(detachedStream); | ||
| return null; | ||
| } |
Member
There was a problem hiding this comment.
Since we detached the stream, if we give up here, aren't we erroneously going to discard the actual data? My understanding of Detachable is that the original stream is now invalid, right?
Contributor
Author
There was a problem hiding this comment.
good catch. Actually this is redundant, the isDirect is already checked at the beginning of the method so I just removed it
lidavidm
reviewed
Jan 14, 2026
Member
lidavidm
left a comment
lidavidm
left a comment
There was a problem hiding this comment.
All builds fail:
Error: Non-test scoped test only dependencies found:
Error: io.grpc:grpc-core:jar:1.78.0:compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Closes #939.