refactor(@angular/cli): remove resolve dependency and use native require.resolve #32276
+11
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ire.resolve This commit removes the `resolve` dependency from `@angular/cli` and replaces its usage with native `require.resolve` via `createRequire`. The `findPackageJson` utility is now only used in migration-only scenarios where the Node.js module caching behavior that prompted the original use of `resolve` is no longer a concern. This reduces the package dependency footprint.
clydin
added
the
action: review
This commit removes the unused `package-tree.ts` utilities, including `getProjectDependencies`, `readPackageJson`, and `PackageTreeNode`. The `findPackageJson` function, which was the only remaining used part, has been moved directly into `commands/update/cli.ts` where it is consumed.
hybrist
approved these changes
Jan 12, 2026
hybrist
approved these changes
Jan 12, 2026
| function findPackageJson(workspaceDir: string, packageName: string): string | undefined { | ||
| try { | ||
| const projectRequire = createRequire(path.join(workspaceDir, 'package.json')); | ||
| const packageJsonPath = projectRequire.resolve(`${packageName}/package.json`); |
Contributor
There was a problem hiding this comment.
There's a small gotcha for this which is that exports fields can mess with resolving package.json. But 99.9% of the time, an Angular app shouldn't have an exports field (and 90% of the remaining time, people should've added package.json to their exports).
Member
Author
There was a problem hiding this comment.
Packages that contain Angular migrations must have a resolvable package.json so in this specific usage we can luckily avoid that situation.
alan-agius4
approved these changes
Jan 13, 2026
alan-agius4
added
action: merge
Member
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the
resolvedependency from@angular/cliand replaces its usage with nativerequire.resolveviacreateRequire. ThefindPackageJsonutility is now only used in migration-only scenarios where the Node.js module caching behavior that prompted the original use ofresolveis no longer a concern. This reduces the package dependency footprint.