fix: treat HttpStatus.UNKNOWN as retryable

[crleona]

Summary

Implements the suggestion from issue #69 to treat HttpStatus.UNKNOWN responses as retriable, similar to TIMEOUT and FAILED statuses. This enhances the SDK's resilience by preventing immediate event loss for unrecognized server responses.

• ResponseProcessor now pushes events back to storage for retry on HttpStatus.UNKNOWN.
• Updated test_worker.py to assert retry behavior for UNKNOWN responses.
• Added a new unit test in test_processor.py to specifically cover UNKNOWN status retry logic.

Checklist

• Does your PR title have the correct title format?
• Does your PR have a breaking change?: No

---

 

---

Note

Low Risk
Small, localized change to retry classification plus test updates; primary risk is altered behavior for UNKNOWN responses potentially causing extra retries in edge cases.

Overview
ResponseProcessor.process_response now treats HttpStatus.UNKNOWN as a retryable response, pushing affected events back to storage instead of immediately invoking callbacks/logging an error.

Tests are updated/added to verify UNKNOWN responses increment event.retry, requeue events, and only trigger callbacks after a subsequent successful send; the worker multithreading test also replaces a busy-wait with a wait_for_workers_idle() helper to reduce flakiness.

^{Written by Cursor Bugbot for commit 2666568. This will update automatically on new commits. Configure here.}

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[macroscopeapp]

Route UNKNOWN HTTP responses to immediate retry in ResponseProcessor.process_response with push_to_storage(events, 0, res) per Issue 69 suggestion

Extend failure handling to treat HttpStatus.UNKNOWN like TIMEOUT and FAILED in processor.py; add unit tests covering unknown status retry in test_processor.py and worker behavior in test_worker.py.

📍Where to Start

Start with the conditional in ResponseProcessor.process_response in processor.py.

---

Macroscope summarized 62998b3. (Automatic summaries will resume when PR exits draft mode or review begins).

[Copilot]

Pull request overview

Updates the SDK’s retry behavior so that HttpStatus.UNKNOWN (e.g., -1 / transient network failures) is treated as retryable, aligning it with TIMEOUT and FAILED handling to reduce event loss on ambiguous transport/server errors.

Changes:

• Treat HttpStatus.UNKNOWN as retryable in ResponseProcessor.process_response.
• Update worker tests to assert retry + eventual success flow for UNKNOWN responses.
• Add a focused unit test ensuring UNKNOWN does not trigger callbacks and increments event.retry.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/amplitude/processor.py	Adds HttpStatus.UNKNOWN to the retryable status set.
src/test/test_worker.py	Updates the unknown-status worker test to validate retry behavior; introduces a helper to wait for worker idleness in the multithreading test.
src/test/test_processor.py	Adds a unit test for ResponseProcessor retry behavior on UNKNOWN.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[crleona]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

[crleona]

Bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

[sojingle]

LGTM!