Merged
Conversation
02b090f to
e6ca015
Compare
Owner
|
Thanks for this! I figured there was a good way to do this, but coming from Java I've always found Dart's soup of keywords in this area to be confusing. I suspect there are some other groups of OrgNodes that could use the same treatment. I thought we might as well call the common interface |
Contributor
Author
|
Defining a interface and consolidating common attributes sound good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This impelements a sealed [1] class which sort of acts as a union tag. This will give us exhaustive switching for every timestamp, like this:
Also, because the OrgGenericTimestamp extends OrgNode, we can access toMarkup() and other methods directly from the OrgGenericTimestamp.
[1] https://dart.dev/language/class-modifiers#sealed