Skip to content

Conversation

@JoshuaKGoldberg
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg commented Jan 31, 2026

Draft PR for reference in triaging #423.

The removed points are:

@babel/runtime isn't explicitly referenced anywhere, but kcd-scripts build fails if it's not there:

> all-contributors-cli@0.0.0-semantically-released build /home/runner/work/cli/cli
> kcd-scripts build

Error: [BABEL]: You should add @babel/runtime as dependency to your package. It will allow reusing "babel helpers" from node_modules rather than bundling their copies into your files. (While processing: /home/runner/work/cli/cli/node_modules/.pnpm/kcd-scripts@16.0.0_@types+node@25.2.3_typescript@5.9.3/node_modules/kcd-scripts/dist/config/babelrc.js)
    at Object.<anonymous> (/home/runner/work/cli/cli/node_modules/.pnpm/kcd-scripts@16.0.0_@types+node@25.2.3_typescript@5.9.3/node_modules/kcd-scripts/dist/config/babelrc.js:32:9)

@JimMadge
Copy link
Member

We might want to bring the commitizen and semantic release packages back as dev dependencies for the release process. I'm not exactly sure what they do.

I expect we would want to keep the existing commit convention and release style just for consistency.

@lwasser
Copy link
Member

lwasser commented Jan 31, 2026

We might want to bring the commitizen and semantic release packages back as dev dependencies for the release process. I'm not exactly sure what they do.

I expect we would want to keep the existing commit convention and release style just for consistency.

Lemme open an issue as I think I'd personally prefer to remove semantic release - but I do want to talk it out as to why!! in case i'm missing something important !!

@lwasser
Copy link
Member

lwasser commented Jan 31, 2026

Oh, actually - can you all have a look at #420 please and respond there?

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review February 10, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants