chore: Remove dependency on lodash #421

jdalrymple · 2026-01-30T04:54:13Z

What: Remove dependency on lodash

Why: ~~In the attempt to move to esm, lodash is a blocker. There are alternatives such as lodash-esm, but alot of the use cases (except for template) are supported by native js.~~ Additional benefit is the reduction in pkg size since lodash is massive!

How: Migrate all lodash usages to native logic, and migrate template to use eta

Checklist:

Documentation
Tests
Ready to be merged
Added myself to contributors table

Related #412

JoshuaKGoldberg · 2026-01-30T21:51:53Z

I'm generally in favor of moving off of Lodash - or at least the parts of it that are now built into JS. But:

In the attempt to move to esm, lodash is a blocker

Why does Lodash block ESM? As of Node.js v20.19.0+, require(esm) is a thing - so we should be fine to use it regardless of CJS/ESM?

jdalrymple · 2026-01-30T22:05:39Z

I'm generally in favor of moving off of Lodash - or at least the parts of it that are now built into JS. But:

In the attempt to move to esm, lodash is a blocker

Why does Lodash block ESM? As of Node.js v20.19.0+, require(esm) is a thing - so we should be fine to use it regardless of CJS/ESM?

New info to me! haha I had to brush back up on the spec. I think eslint/prettier fires off an error about it since its recommended that you do not use require in esm.

That being said, we probably shouldnt be mixing ways to load modules if possible.

Let me see if i can get the exact issue i saw and post it in the PR

jdalrymple · 2026-01-30T22:23:47Z

@JoshuaKGoldberg It might have been this eslint error:

Cannot use import declarations in modules that export using CommonJS (module.exports = 'foo' or exports.bar = 'hi')

When i tried to perform the import _ from 'lodash/fp'. So yea, using require should be "ok". If thats something youd like to do, i can kill this pr?

JoshuaKGoldberg · 2026-01-31T01:04:14Z

Cannot use import declarations ...

Weird, that doesn't look like an ESLint error. Where did you see it / how did you get that to happen? Can you paste the full error? (I don't reproduce locally)

kill this pr

Well, removing a large dependency is always nice 😄 I'm not against the PR if you want to keep it going! But I just don't think we need it for the yargs update or otherwise.

jdalrymple · 2026-01-31T16:43:01Z

Weird, that doesn't look like an ESLint error. Where did you see it / how did you get that to happen? Can you paste the full error? (I don't reproduce locally)

How i create it is by setting the module type in the pkg json, and then switching the import to use "import" instead of require:

lwasser · 2026-01-31T19:08:31Z

@jdalrymple, My apologies, I just broke your PR with merge conflicts when we merged my ESLINT config pr. 🙃
this will likely happen again in both directions 🤣

jdalrymple · 2026-01-31T23:19:26Z

hahah no worries, ill sort out the conflicts over the next couple days

jdalrymple · 2026-02-01T05:39:20Z

@JoshuaKGoldberg I was able to bump yargs without doing all the esm things in one ticket, see #431

JoshuaKGoldberg · 2026-02-02T14:49:32Z

setting the module type in the pkg json

Aha there's an issue! I think you discovered this in the PR, but just to say it here: there shouldn't be a need to do that. The only entries that should need to be changed in the package.json are under dependencies/devDependencies/similar.

jdalrymple · 2026-02-02T17:15:03Z

setting the module type in the pkg json

Aha there's an issue! I think you discovered this in the PR, but just to say it here: there shouldn't be a need to do that. The only entries that should need to be changed in the package.json are under dependencies/devDependencies/similar.

Not quite sure I follow. Are you saying that nothing* needs to be changed in the package.json to have the library be recognized as esm?

JoshuaKGoldberg · 2026-02-02T17:28:43Z

Depends what you mean by "have the library be recognized as esm"?

If by "library" you mean lodash: correct, we can just change the version range as you did in chore: Update yargs to v18 #431
If by "library" you mean all-contributors/cli: we'd have to add "type": "module" in package.json, which is definitely out of scope for dropping a dependency like lodash

jdalrymple · 2026-02-05T04:45:29Z

Anything missing in this that i should add/cover?

JoshuaKGoldberg · 2026-02-05T14:24:43Z

package.json

    "async": "^3.1.0",
    "chalk": "^5.6.2",
    "didyoumean": "^1.2.1",
+    "eta": "^4.5.0",


[Praise] TIL that eta is the recommended replacement for _.template. Cool! https://www.npmjs.com/package/lodash.template

JoshuaKGoldberg

LGTM, what a great contribution - thanks for doing all this manual work! 🙌

Because this touches a lot of tricky stuff, I'd definitely want another review from a maintainer. I think it'd be good to double-check sure CI is working & tests are running well before merging. But no blockers that I can see.

lwasser · 2026-02-09T01:10:49Z

thanks for the review @JoshuaKGoldberg !! @jdalrymple two questions - are you interested in becoming a part of our maintainer team here? you've been helping so so much!

second, I will review this in the next few days. i'll test things locally - and give it a closer review. My apologies for the delays!!

lwasser · 2026-02-10T02:56:01Z

hey there @jdalrymple i'm curious - did you run an all-contributors add command locally? I just tried to run a simple command to add (init works fine)

all-contributors add lwasser code

i'm getting a TypeError

{
                             ^

TypeError: util.template is not a function
    at /Users/leahawasser/Documents/GitHub/allcontributors/cli/dist/util/git.js:57:30
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

Node.js v22.22.0

but then when I try to fix that I get another error - circular reference. So i'm wondering if you see the same thing? Thank you!!

lwasser · 2026-02-10T03:03:06Z

src/util/index.js

  git: require('./git'),
  markdown: require('./markdown'),
  url: require('./url'),
+  template: require('./template'),


I ran into a problem here with template loading in time. So moving git to the end helped with that issue.

i'm a bit confused as there seems to be a circular import involved here.

Weirdddddd, ill give it a look and follow up 🫡

jdalrymple · 2026-02-10T15:32:32Z

hey there @jdalrymple i'm curious - did you run an all-contributors add command locally? I just tried to run a simple command to add (init works fine)

all-contributors add lwasser code

i'm getting a TypeError
{
                             ^

TypeError: util.template is not a function
    at /Users/leahawasser/Documents/GitHub/allcontributors/cli/dist/util/git.js:57:30
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)

Node.js v22.22.0
but then when I try to fix that I get another error - circular reference. So i'm wondering if you see the same thing? Thank you!!

Ill check this one as well, and write a test so its not missed again 🫡

jdalrymple · 2026-02-10T15:33:28Z

thanks for the review @JoshuaKGoldberg !! @jdalrymple two questions - are you interested in becoming a part of our maintainer team here? you've been helping so so much!

second, I will review this in the next few days. i'll test things locally - and give it a closer review. My apologies for the delays!!

No apology needed! Were all running on little time here 😂 I'm down! though time commitment might be hit and miss, I'm game to help regardless.

# Conflicts: # src/util/git.js # Conflicts: # src/generate/index.js # src/init/init-content.js

jdalrymple · 2026-02-10T15:33:53Z

Converted to a draft until i have time to check the above notes

jdalrymple marked this pull request as ready for review January 30, 2026 04:55

jdalrymple force-pushed the dep/remove-lodash branch from 52c8b33 to 94d87eb Compare February 1, 2026 05:23

JoshuaKGoldberg reviewed Feb 5, 2026

View reviewed changes

JoshuaKGoldberg approved these changes Feb 5, 2026

View reviewed changes

lwasser reviewed Feb 10, 2026

View reviewed changes

jdalrymple marked this pull request as draft February 10, 2026 15:32

Removing lodash dep

3ad2a4a

# Conflicts: # src/util/git.js # Conflicts: # src/generate/index.js # src/init/init-content.js

jdalrymple force-pushed the dep/remove-lodash branch from 94d87eb to 3ad2a4a Compare February 10, 2026 15:33

lwasser mentioned this pull request Feb 11, 2026

chore: migrate build/ babel to native configuration #437

Draft

4 tasks

chore: Remove dependency on lodash #421

Are you sure you want to change the base?

chore: Remove dependency on lodash #421

Uh oh!

Conversation

jdalrymple commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg commented Jan 30, 2026

Uh oh!

jdalrymple commented Jan 30, 2026

Uh oh!

jdalrymple commented Jan 30, 2026

Uh oh!

JoshuaKGoldberg commented Jan 31, 2026

Uh oh!

jdalrymple commented Jan 31, 2026

Uh oh!

lwasser commented Jan 31, 2026

Uh oh!

jdalrymple commented Jan 31, 2026

Uh oh!

jdalrymple commented Feb 1, 2026

Uh oh!

JoshuaKGoldberg commented Feb 2, 2026

Uh oh!

jdalrymple commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoshuaKGoldberg commented Feb 2, 2026

Uh oh!

jdalrymple commented Feb 5, 2026

Uh oh!

JoshuaKGoldberg Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

lwasser commented Feb 9, 2026

Uh oh!

lwasser commented Feb 10, 2026

Uh oh!

lwasser Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

jdalrymple Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

jdalrymple commented Feb 10, 2026

Uh oh!

jdalrymple commented Feb 10, 2026

Uh oh!

jdalrymple commented Feb 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jdalrymple commented Jan 30, 2026 •

edited

Loading

jdalrymple commented Feb 2, 2026 •

edited

Loading