refactor: Update calls to prettier functions to account for latest async API #403
Conversation
# Conflicts: # package.json # src/init/__tests__/__snapshots__/add-contributors-list.js.snap
b3e76ac to
71ac26b
Compare
f0df138 to
cc537b7
Compare
|
|
||
| const absentFile = './abc' | ||
| const absentConfileFileExpected = `Configuration file not found: ${absentFile}` | ||
| const absentConfigFileExpected = `Configuration file not found: ${absentFile}` |
There was a problem hiding this comment.
[Praise] Nice catch 😄
There was a problem hiding this comment.
I try to keep my clean up scope creeps to a minimum, but somethings i just hadddd to fix haha
|
Once this is in, ill look at the next blocked PR 🫡 |
|
@jdalrymple thank you for this refactor! I have a few questions! With these refactors we are moving towards ES modules (yay!) ✨ But when i build the package, link/install and run this locally i get an error:
npm run build We could also merge this and just add that in a separate pr (if needed) bare with me! and if this is what others see, we probably need to add a test or two to catch it. but please let's start with making sure you can see the same issue that I see locally! THANK YOU!! |
|
Ok so when i don't add type:module (maybe the build system standardizes things? i haven't looked yet... i get a TYPEERROR related to yargs I think this might be a yargs version error . I looked at the tests when i merged pr's but i didn't test the CLI each time assuming test coverage. |
|
Ok it was bugging me - the fix is actually pinning yargs back to |
lwasser
left a comment
There was a problem hiding this comment.
opening a quick pr to modify yargs
What: Due to the prettier update, the API has changed - now exposing async functions
Why: API changes with latest dep version no longer support sync functions
How: Went through each related function and updated them accordingly
Checklist:
Related to #375