-
Notifications
You must be signed in to change notification settings - Fork 147
test(add-contributors-list): Improve the clarity of the add-contributors-list tests
#396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(add-contributors-list): Improve the clarity of the add-contributors-list tests
#396
Conversation
add-contributors-list tests
|
I need to double check the snapshots. Ill get back to this later today |
|
@jdalrymple thank you again and again for this. I just opened #397 to set up our tests on GitHub Actions. We don't have proper access to Circle CI right now, and I think GitHub is simpler for us. Just so you know!! I merged a few things earlier, so you can rebase when you have time!! And finally, all of the deps will get updated via Dependabot as soon as my test pr is merged. We are so grateful to have your help here, thank you again!! |
|
@all-contributors please add @jdalrymple for tests |
|
@jdalrymple already contributed before to test |
cd5f07e to
bdce486
Compare
Sounds good! Happy to help 🫡 |
lwasser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! thank you again. cleaner tests docs and the move to async/await is much nicer!!
What: Switch to async/await syntax for the add-contributors-list test file, and fixed one of the unlink function call
Why: It was causing an issue during the overhaul here #375
How: Switch to async/await and fs/promises
Checklist: