Skip to content

Conversation

@jdalrymple
Copy link
Contributor

@jdalrymple jdalrymple commented Jan 24, 2026

What: Switch to async/await syntax for the add-contributors-list test file, and fixed one of the unlink function call

Why: It was causing an issue during the overhaul here #375

How: Switch to async/await and fs/promises

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@jdalrymple jdalrymple changed the title test(add-contributors-list): improve the clarity of the tests test(add-contributors-list): Improve the clarity of the add-contributors-list tests Jan 24, 2026
@jdalrymple jdalrymple marked this pull request as draft January 24, 2026 19:01
@jdalrymple
Copy link
Contributor Author

I need to double check the snapshots. Ill get back to this later today

@lwasser
Copy link
Member

lwasser commented Jan 24, 2026

@jdalrymple thank you again and again for this. I just opened #397 to set up our tests on GitHub Actions. We don't have proper access to Circle CI right now, and I think GitHub is simpler for us. Just so you know!!

I merged a few things earlier, so you can rebase when you have time!! And finally, all of the deps will get updated via Dependabot as soon as my test pr is merged. We are so grateful to have your help here, thank you again!!

@lwasser
Copy link
Member

lwasser commented Jan 24, 2026

@all-contributors please add @jdalrymple for tests

@allcontributors
Copy link
Contributor

@lwasser

@jdalrymple already contributed before to test

@jdalrymple jdalrymple force-pushed the test/add-contributors-list branch from cd5f07e to bdce486 Compare January 24, 2026 22:44
@jdalrymple jdalrymple marked this pull request as ready for review January 24, 2026 22:45
@jdalrymple
Copy link
Contributor Author

@jdalrymple thank you again and again for this. I just opened #397 to set up our tests on GitHub Actions. We don't have proper access to Circle CI right now, and I think GitHub is simpler for us. Just so you know!!

I merged a few things earlier, so you can rebase when you have time!! And finally, all of the deps will get updated via Dependabot as soon as my test pr is merged. We are so grateful to have your help here, thank you again!!

Sounds good! Happy to help 🫡

Copy link
Member

@lwasser lwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! thank you again. cleaner tests docs and the move to async/await is much nicer!!

@lwasser lwasser merged commit 84ac3ed into all-contributors:main Jan 25, 2026
1 check passed
@jdalrymple jdalrymple deleted the test/add-contributors-list branch January 28, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants