show half hour marks on the left-hand column

[dgrant]

Here is the "show half hours change", now rebased on develop branch.

[dgrant]

Should I create a new method with interpretTime(int hour, minutes) and leave the original interpretTime(int hour) to not break people?

[entropitor]

Yes, preferably.

[dgrant]

Hold on, that doesn't actually help. Just by adding the interpretTime(int hour, int minutes) to the interface will break an client implementing that interface. Only if we had a base class and people extended that, could we then add a method to the interface and not break consumer.

[entropitor]

Maybe have a "subinterface"?

Because a breaking change for this small behaviour change is maybe not what we want.

[dgrant]

Rebased changes

[dgrant]

Can this be merged?

[entropitor]

This is still a breaking change, no?

Because I'm not sure if I want to break the library for something small like this.

[marunjar]

hi, would be great if this pr can be merged

i think this extension of the interface is a very small breaking change and can be easily fixed by anyone.

[entropitor]

Fine for me. @alamkanak Is it ok for you as well?

@dgrant Can you rebase onto master again?

[dgrant]

@caske33 Ok, I've rebased it on master.

[entropitor]

Can you squash those commits?

Also, there still seems to be a merge conflict. Maybe try rebasing on develop?

Thank you for your patience! 💯

[dgrant]

Ok, finally cleaned everything up. Sorry for the delay.

[marunjar]

👍

[varsha1609]

showHalfHours not working , Need Help

[Gurpreet258]

how to use timespacing. ? showHalfHours changes the left column to show time with half hour intervals . rest all working same i.e on hour basis. Need urgent help