This repository was archived by the owner on Dec 11, 2019. It is now read-only.
Draft
Conversation
neongreen
reviewed
Jul 2, 2019
| package codesearch.core.index.indexer | ||
|
|
||
| import cats.effect.{ContextShift, Sync} | ||
| import codesearch.core.index.directory.СindexDirectory.HaskellCindex |
Member
There was a problem hiding this comment.
Please fix the Cyrillic C in "CindexDirectory" while you're at it, and all other Cs in the codebase.
| languagesConfig { | ||
| haskell { | ||
| repository = "hackage" | ||
| repoIndexUrl = "http://hackage.haskell.org/packages/index.tar.gz" |
| concurrentTasksCount = 30 | ||
| } | ||
| javascript { | ||
| repository = "npm" |
| def upsert(name: String, version: String, repository: String): F[Int] = { | ||
| sql""" | ||
| INSERT INTO package(name, version, repository, updated_at) | ||
| VALUES ($name, $version, $repository, now()) |
Member
There was a problem hiding this comment.
Will this escape name? Because otherwise we might get an SQL injection.
Contributor
Author
There was a problem hiding this comment.
Ok, I will check it.
| repoArchivePath = "./data/meta/rust/archive.zip" | ||
| repoPath = "./data/meta/rust/" | ||
| concurrentTasksCount = 30 | ||
| ignoreFiles = ["test-max-version-example-crate", "version-length-checking-is-overrated", "config.json", "archive.zip", ".git"] |
Member
There was a problem hiding this comment.
Why is config.json excluded? (Not saying it shouldn't be, just asking why)
Contributor
Author
There was a problem hiding this comment.
@neongreen I can't answer why is so =( but it was originally. I will remove it, thanks.
| def batchUpsert(packages: List[PackageIndexTableRow]): F[Int] = { | ||
| Update[PackageIndexTableRow]( | ||
| """ | ||
| |INSERT INTO repository_index(name, version, repository) |
Member
There was a problem hiding this comment.
What are the pipes doing here?
Contributor
Author
There was a problem hiding this comment.
@neongreen it's Scala multi-row strings definition syntax.
neongreen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now this PR is WIP. Not compiling.