Fix CI failing due to relative BUNDLE_GEMFILE path #297
+20
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use absolute path for BUNDLE_GEMFILE to prevent path resolution issues when working directory changes to test/dummy - Pin minitest to ~> 5.0 (v6 moved Mock to separate gem) - Add Rails and sqlite3 to API gemfiles for test compatibility - Remove conflicting rails version from gemspec (gemfiles handle it)
khasinski
force-pushed
the
fix/ci-bundle-gemfile-path
branch
from
1d5aea5 to
a7b19be
Compare
Contributor
|
🫡🧂🖖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
test/dummy${{ github.workspace }}/${{ matrix.gemfile }}at job levelcd test/dummywithworking-directorydirective for cleaner executionProblem
The CI was failing with:
This happened because BUNDLE_GEMFILE was set to a relative path (
gemfiles/rails8.gemfile), and when the database setup step changed totest/dummy, bundler resolved the path from that directory.Additionally minitest 6 release broke the test setup, pinning version to 5 fixes the issue for now.
Test plan