-
Notifications
You must be signed in to change notification settings - Fork 160
Add STM32F303Nucleo. Disable broken examples. #836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Lint Results
ℹ️ Additional issues on unchanged lines
The following 1 issue(s) exist but are not on lines changed in this PR:
examples/stmicro/stm32/build.zig:19: TODO style comments need to have a linked microzig issue on the same line.
|
@henryrgithub we compile these examples in CI, what compilation errors were you seeing? |
|
Ah, looking closer, the errors are
and similar. The errors go away with -Doptimize=ReleaseFast or similar. I've uncommented the examples, though it might be nice to force strip of debug symbols on those. Fair on the commented lines in board definition, I've deleted them and the unused RCC call. |
|
Debug symbol are irrelevant to what actually gets written on flash. I have a similar issue with ch32v, as they typically have very little storage. What matters is not the size of the ELF, but rather what is written to flash, and debug symbols and such are not. |
Hello! I've got blinky working on the STM32F303 Nucleo board. I disabled some examples that weren't building for the STM32F1xx.