Skip to content

Always use LLD to link when using clang to build #8204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dschuff merged 4 commits into from
Jan 14, 2026
+5 −1
Merged

Always use LLD to link when using clang to build #8204

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
925ece4
Always use LLD to link when using clang to build
dschuff Jan 14, 2026
6af266a
Exclude macOS
dschuff Jan 14, 2026
20cb7e2
Add Mac comment.
dschuff Jan 14, 2026
81048bd
Update CMakeLists.txt
kripken Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,11 +221,15 @@ if(NOT MSVC AND NOT EMSCRIPTEN)
endif()
endif()

# The version of clang currently on our Mac bots doesn't seem to support this flag.
if (CMAKE_CXX_COMPILER_ID MATCHES "Clang" AND (LINUX OR WINDOWS))
Copy link
Member

@kripken kripken Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment why not MacOS?

Copy link
Member

@kripken kripken Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I am guessing the reason is that it is always used there..?)

Copy link
Member Author

@dschuff dschuff Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the opposite; lld historically hasn't had good support for Mach-O. I'm not sure what the current status is but the version of Clang in the SDK on the bots here doesn't even support -fuse-ld=lld, so I figured it wasn't really worth investigating.

add_link_flag("-fuse-ld=lld")
endif()

if(BYN_ENABLE_LTO)
if(NOT CMAKE_CXX_COMPILER_ID MATCHES "Clang")
message(FATAL_ERROR "ThinLTO is only supported by clang")
endif()
add_link_flag("-fuse-ld=lld")
set_property(GLOBAL APPEND PROPERTY JOB_POOLS link_job_pool=2)
set(CMAKE_JOB_POOL_LINK link_job_pool)
add_compile_flag("-flto=thin")
Expand Down
Loading