Open
Conversation
Notices refactor to multiple classes
Tooting my own horn, I know. I just like to make it easier for people to use this library, without having to prefix everything manually.
Translations support in all notices
Closed
Get rid of all the specs, as that's impossible to run on PHP 5.2 as well as on modern PHP versions. Going full PhpUnit.
PhpUnit implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be an ongoing pull request until we're 100% happy with the big 2.0 drop. I'm going to use this pull request to tweak final things, get CI running and probably just to go hit that big, green merge button once it's all finished...