Fix created mode rules firing on modified files #83
+65
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The capture_prompt_work_tree.sh script was incorrectly capturing only "changed files" (git diff) instead of "all tracked files" (git ls-files) as the baseline for compare_to: prompt mode. This caused created: mode rules to incorrectly fire when existing files were modified, because those files weren't in the baseline (they weren't "changed" at prompt time, just existing). Fix: Change baseline capture to use git ls-files which captures ALL tracked files. This ensures: - Newly created files (not in baseline) -> trigger created: rules - Modified existing files (in baseline) -> do NOT trigger created: rules Also adds a manual test case for created mode to verify this behavior.
The function was incorrectly subtracting the baseline files from the current staged files, which meant modified files were never detected (they appear in both sets and get subtracted out). Now the function simply returns ALL files with staged changes, which is what trigger/safety, set, and pair mode rules need to detect file modifications during the agent response. The baseline file is only used by get_created_files_prompt() to detect truly NEW files for created: mode rules. This completes the fix for the created mode rules bug - both issues are now resolved: 1. Baseline captures ALL tracked files (not just changed) 2. Changed files detection returns ALL staged files (not just new)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The capture_prompt_work_tree.sh script was incorrectly capturing only "changed files" (git diff) instead of "all tracked files" (git ls-files) as the baseline for compare_to: prompt mode.
This caused created: mode rules to incorrectly fire when existing files were modified, because those files weren't in the baseline (they weren't "changed" at prompt time, just existing).
Fix: Change baseline capture to use git ls-files which captures ALL tracked files. This ensures:
Also adds a manual test case for created mode to verify this behavior.