Make compares_to field required in rules #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously compare_to was optional with a default of "base". Now it must be explicitly specified in all rule definitions, making the change detection baseline configuration explicit rather than implicit. Changes: - Update schema to require compare_to field - Remove default value from rules parser - Update documentation to reflect required status - Add test for missing compare_to validation - Update all test rule definitions to include compare_to
All rule files now require the compare_to field. Updated: - .deepwork/rules/architecture-documentation-accuracy.md - .deepwork/rules/readme-accuracy.md - .deepwork/rules/standard-jobs-source-of-truth.md - .deepwork/rules/version-and-changelog-update.md - src/deepwork/standard_jobs/deepwork_rules/rules/skill-md-validation.md Also ran deepwork install to sync changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously compare_to was optional with a default of "base". Now it must be explicitly specified in all rule definitions, making the change detection baseline configuration explicit rather than implicit.
Changes: